generated from codinglabsau/laravel-package-skeleton
-
Notifications
You must be signed in to change notification settings - Fork 0
Next #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
stevethomas
wants to merge
48
commits into
main
Choose a base branch
from
next
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Next #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the documentation, testing, and deployment workflows for the project, as well as several codebase and configuration updates. The most important changes are grouped below by theme.
Documentation and onboarding improvements:
README.mdhas been extensively rewritten to provide clearer, step-by-step onboarding instructions, improved explanations of domain and multi-tenant configurations, and enhanced guidance for development and debugging. The manifest example has been updated to reflect new configuration keys and best practices. [1] [2] [3] [4] [5]Testing and CI enhancements:
.github/workflows/test.yml) to automate testing on push and pull requests tomain, including Slack notifications for failures.phpunit.xmlconfiguration file to enable PHPUnit-based testing.composer.jsonto add Pest as a dev dependency, configure Pest plugin support, and move Spatie Ray to dev dependencies. [1] [2]Codebase and deployment workflow changes:
BuildCommandandDeployCommandto inherit fromSteppedCommand, simplifying their structure and progress output handling. [1] [2] [3] [4] [5] [6]SyncStandaloneRecordSetStepfor standalone apps, clarifying deployment logic.Configuration and manifest updates:
account-id,vpc,artefacts-bucket,key-pair, and multi-tenant domain settings, supporting more flexible AWS setups. [1] [2]Code quality and AWS integration improvements:
tagsmethod and updatedaccountIdretrieval using manifest values. [1] [2]These changes collectively improve the project's usability, reliability, and maintainability.